Merged
Conversation
Signed-off-by: dzdidi <dzdidi@protonmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds configurable pacing to the periodic probing routine by introducing delays between probes (per amount) and between peers, and wiring these new settings through config parsing and example configs.
Changes:
- Add
probe_delay_secandpeer_delay_secto probing configuration (with defaults) and propagate into runtime probing loop. - Insert
tokio::time::sleepdelays after probe attempts and between peers during a probing cycle. - Update example configuration templates/help output to include the new delay fields.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Applies new per-probe and per-peer delays during the probing loop and extends startup logging. |
| src/config.rs | Extends deserialized probing config with new delay fields + defaults; updates config help text. |
| src/cli.rs | Extends the in-memory probing config passed into runtime with delay fields. |
| prober_config.json.example | Adds delay keys to the prober config example (but key naming may not match code). |
| config.example.json | Adds delay fields to the primary config example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR adds configurable pacing to the periodic probing routine by introducing delays between probes (per amount) and between peers, and wiring these new settings through config parsing and example configs.
Changes:
probe_delay_secandpeer_delay_secto probing configuration (with defaults) and propagate into runtime probing loop.tokio::time::sleepdelays after probe attempts and between peers during a probing cycle.